Repository navigation
Restore submit button double-click guard on summary page - #471
Merged
Merged
Conversation
The prevent-multiple-clicks class added in #413 was dropped when the i18n-linting branch (#436) was merged, leaving the summary submit button with preventDoubleClick: false and no client-side guard at all. Users clicking Submit repeatedly on a slow submission (e.g. many file uploads) could trigger duplicate form submissions. Re-add the class so debounce-click.js ignores repeat clicks for 10s, and add a test that renders the real summary page, runs initDebounceClick() against it and asserts a double click only submits the form once. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Scullyon
approved these changes
Sep 21, 2026
davidjamesstone
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The prevent-multiple-clicks class added in #413 was dropped when the i18n-linting branch (#436) was merged, leaving the summary submit button with preventDoubleClick: false and no client-side guard at all. Users clicking Submit repeatedly on a slow submission (e.g. many file uploads) could trigger duplicate form submissions.
Re-add the class so debounce-click.js ignores repeat clicks for 10s, and add a test that renders the real summary page, runs initDebounceClick() against it and asserts a double click only submits the form once.
Proposed change
Jira ticket:
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).