COMP: Use single export() call to fix namespace corruption - #154
Open
blowekamp wants to merge 1 commit into
Open
COMP: Use single export() call to fix namespace corruption#154blowekamp wants to merge 1 commit into
blowekamp wants to merge 1 commit into
Conversation
Replacing three APPEND export() calls with one non-APPEND call fixes a namespace corruption bug where CMake prepends the DCMTK:: namespace to dependency targets (e.g. ITK codec targets) that belong to other export sets. CMake's HandleMissingTarget only searches other registered export sets when not in append mode. In append mode it blindly prepends the current namespace, producing DCMTK::ITK::ITKZLIBModule instead of the correct ITK::ITKZLIBModule in DCMTKTargets.cmake. The file(WRITE)+3xAPPEND pattern was used only to accumulate targets across multiple calls; combining them into a single export() call is equivalent and avoids the append-mode shortcut.
dzenanz
approved these changes
Jul 14, 2026
hjmjohnson
approved these changes
Jul 15, 2026
hjmjohnson
left a comment
hjmjohnson
left a comment
There was a problem hiding this comment.
Thanks @blowekamp Reviewed, built local, and confirmed this resolved the linking issues downstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing three APPEND export() calls with one non-APPEND call fixes a namespace corruption bug where CMake prepends the DCMTK:: namespace to dependency targets (e.g. ITK codec targets) that belong to other export sets.
CMake's HandleMissingTarget only searches other registered export sets when not in append mode. In append mode it blindly prepends the current namespace, producing DCMTK::ITK::ITKZLIBModule instead of the correct ITK::ITKZLIBModule in DCMTKTargets.cmake.
The file(WRITE)+3xAPPEND pattern was used only to accumulate targets across multiple calls; combining them into a single export() call is equivalent and avoids the append-mode shortcut.