Use errors.New for preformatted error messages - #357
Open
cl2t wants to merge 1 commit into
Open
Conversation
The unexpected-call messages are already assembled strings. Construct their errors directly instead of passing non-constant formats to Errorf. This preserves the messages and avoids printf analyzer diagnostics in recent Go GOPATH builds. Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
cl2t
force-pushed
the
fix-preformatted-errors
branch
from
September 14, 2026 14:19
81daeb4 to
9ddad4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.27's printf analyzer reports non-constant format strings for the
fmt.Errorf(msg)calls insqlmock.gowhen building in GOPATH mode. These messages are already constructed from fixed strings and need no formatting.Use
errors.New(msg)for those calls and the matching Ping case. Error messages and the public API remain unchanged; no new dependency or Go version requirement is introduced.Validation:
go vetand the existing race/coverage test suite pass on Go 1.26.3.-race. The integration run also covered the examples using the separately fixedsqlstructdependency.Assisted-by: Codex:GPT-6