Skip to content

Reject conflicting exec argument expectations #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bolt4243 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reject conflicting exec argument expectations #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3790812
Reject conflicting exec argument expectations
Bolt4243 Sep 9, 2026
f2eeaee
Use a matching exec example in the regression test
scrintisnotfun Sep 9, 2026
5cb26b3
Check the exec guard panic in the regression test
scrintisnotfun Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion expectations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ type ExpectedExec struct {
// arguments an sqlmock.Argument interface can be used to match an argument.
// Must not be used together with WithoutArgs()
func (e *ExpectedExec) WithArgs(args ...driver.Value) *ExpectedExec {
if len(e.args) > 0 {
if e.noArgs {
panic("WithArgs() and WithoutArgs() must not be used together")
}
e.args = args
Expand Down
11 changes: 11 additions & 0 deletions expectations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,17 @@ func TestExecWithNoArgsAndWithArgsPanic(t *testing.T) {
mock.ExpectExec("^INSERT INTO user").WithArgs("John").WithoutArgs()
}

func TestExecWithoutArgsAndWithArgsPanic(t *testing.T) {
const expectedPanic = "WithArgs() and WithoutArgs() must not be used together"
defer func() {
if r := recover(); r != expectedPanic {
t.Fatalf("expected panic %q, got %v", expectedPanic, r)
}
}()
mock := &sqlmock{}
mock.ExpectExec("UPDATE invoices SET status = \\?").WithoutArgs().WithArgs("paid")
}


func TestQueryWillReturnsNil(t *testing.T) {
t.Parallel()
Expand Down