Repository navigation
ci: test on Node 22/24/26 and comark min/latest, add knip - #11
Merged
Merged
Conversation
The plugin imports Node, ElementNodeAttributes and ComarkPluginFactory from comark, which only exist since 0.7.0. Older versions fail at runtime (< 0.6) or ship broken types (0.6).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developas well asmain.0.7.0(lowest supported) andlatest, each running typecheck, tests and build.dist/on Node 20 to keepengines.node >=20honest (vitest and tsdown no longer support Node 20).pnpm knip, run in CI) and stop exporting the two unused types it flagged.Fix
peerDependencies.comarkgoes from>=0.4.0to>=0.7.0. The plugin importsNode,ElementNodeAttributesandComarkPluginFactoryfrom comark, which only exist since 0.7.0: it fails at runtime before 0.6 and ships broken types on 0.6. Worth mentioning in the next release notes.