Guard empty fluid extraction in ItemBloodContainer.consume to prevent broom tick crash#1188
Merged
rubensworks merged 1 commit intomaster-26from Apr 15, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/CyclopsMC/EvilCraft/sessions/ed154074-76a3-4b2b-bb3b-33a538f1545a Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rubensworks
April 15, 2026 15:28
View session
Coverage Report for CI Build 24463199897Coverage increased (+0.002%) to 36.703%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A broom energy drain path can call
ItemBloodContainer.consumewhen the fluid handler’s selected resource is empty. On NeoForge, extractingminecraft:emptythrowsIllegalArgumentException, causing an entity tick crash.Root cause
consume(...)fetchedfluidHandler.getResource(0)and always calledextract(...), even when that resource was empty.Change
ItemBloodContainer.consume.drained = 0) and existing fallback logic (drain from other containers / return drained stack) remains unchanged.Behavioral impact
extract(minecraft:empty, ...)calls while preserving existing blood consumption semantics for valid fluid resources.