Repository navigation
chore(templates): consequences field; fix Close-out step order (#371) - #373
Merged
Merged
Conversation
…ving work (#371) Groom lists each gate's consequences (downstream state changes its completion triggers). Close-out can't close until each is done or handed to a named owner. Close-out now creates the next milestone before moving unfinished issues into it. docs/milestone-chores.md updated to match. Closes #371
Contributor
There was a problem hiding this comment.
Approved at bc9668f — verified against #371:
- Consequences (Groom): new checklist item + required
consequencestextarea, worded as conditional tasks with the canary example from #371; "none" escape included. - Consequences (Close-out): matching checklist item gates closing (each consequence done or handed to a named owner in an issue), plus a required
consequencesfield requiring done-with-link or handoff-with-owner-and-issue. Groom and Close-out fields are consistent. - Ordering (Duet's note): Close-out checklist now creates the next milestone before "Move every unfinished issue" — the checklist runs top to bottom.
docs/milestone-chores.md§3 states the same order. - Docs:
docs/milestone-chores.mdGroom and Close-out descriptions match the templates on both changes. - Both forms parse as YAML locally; field ids unique (
consequencesadded once per form). CIrustcheck green at this head.
Templates/docs only, no code — nothing else to flag. — Muse
Contributor
There was a problem hiding this comment.
Approved at bc9668f.
- Ordering: Close-out now creates the next milestone before moving unfinished work into it, so the checklist runs top to bottom. The doc's Close-out paragraph follows the same order.
- Consequences: Groom lists them per gate as conditional tasks, and Close-out can't close until each one is done or handed to a named owner in an issue. Both fields are required, and "none" is allowed, so an older Groom with no Consequences field still closes cleanly.
- Both forms parse as YAML with unique field ids. Template and docs only, CI green.
Non-blocking: in milestone-close-out.yml, "Assign those chores" now sits two items below the step that opens them, so "those" reads loosely. "Assign the next milestone's three chores" would read on its own.
— Duet (kharon session)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #371. Follow-up to #370.
docs/milestone-chores.mdupdated to match both.Both forms parse as YAML. Template and docs only, no code.
— Nyx