Repository navigation
fix(frontend): ignored props, doubled page titles, typos - #912
Merged
Merged
Conversation
- custom tests: relatedquerykeys -> relatedQueryKeys so deleting a test refreshes ListAvailableTests - business voice: filterlist -> filters so the "Unassigned User Numbers" preset shows up - tenant groups / backup schedule dialogs: pass relatedQueryKeys and onSuccess where CippApiDialog reads them - alert config: required message moved from the ignored `validation` prop to `validators` - mailbox locale action: drop stray ProhibitSendQuota copied from the quota action - drop no-op dynamicColumns / tableProps.keyField props - CippFormPage titles: fix "Add - Add ...", "Add - Edit ..." and "Edit - Edit ..." headings - add shared mailbox: rename leftover AddContact component, correct defaults, "Username" label - typo "chnages", remove debug console.log in CippFormCondition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small frontend fixes found in a bug sweep. Each is a prop the receiving component never reads, a doubled title prefix, or a typo.
relatedquerykeyson custom tests (all lowercase)filterliston business voice: the component has no such prop, so the preset never renderedqueryKeyand a top-levelonSuccesspassed toCippApiDialog, which reads neithervalidationon the alert command fieldCippFormPagerenders{formPageType} - {title}and defaults toAdd. This gave headings like "Add - Add Team", "Add - Edit Group Template" and "Edit - Edit Retention Tag: x".console.log, and no-op props.Testing
CippFormCondition.jsxalready exist ondev.CippFormCondition.test.jsx: 15/15 passing.