Skip to content

Add cherry_grove to Stronghold biomes exclusion list #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xpple wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add cherry_grove to Stronghold biomes exclusion list #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4578b0f
Add `cherry_grove` to Stronghold biomes exclusion list
xpple Apr 17, 2025
61c20e9
Apply fix for MC-278965
xpple Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion biomes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ enum MCVersion
MC_1_21_1,
MC_1_21_3,
MC_1_21_WD, // Winter Drop, version TBA
MC_1_21 = MC_1_21_WD,
MC_1_21_9,
MC_1_21 = MC_1_21_9,
MC_NEWEST = MC_1_21,
};

Expand Down
5 changes: 4 additions & 1 deletion finders.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,12 +817,15 @@ int isStrongholdBiome(int mc, int id)
return 0;
case mushroom_field_shore:
return mc >= MC_1_13;
case stone_shore:
case stone_shore: // stony_shore
return mc <= MC_1_17;
case bamboo_jungle:
case bamboo_jungle_hills:
// simulate MC-199298
return mc <= MC_1_15 || mc >= MC_1_18;
case cherry_grove:
// see MC-278965
return mc >= MC_1_21_9;
case mangrove_swamp:
case deep_dark:
return 0;
Expand Down