Repository navigation
Point the content conventions at the shared docs home - #21
Merged
Merged
Conversation
The product-wide content rules now live in CuWilliams/shared-docs, under gfpricechecker/CONTENT_CONVENTIONS.md, alongside the platform-independent PRODUCT_DEFINITION.md. The iOS repo's claude.md became a pointer in GFPriceChecker#57; without the same change here the duplication this was meant to end simply continues in the other direction, with two repos each holding a full copy of a rule that is legal exposure. Claude.md's Content Conventions section gains a header naming the shared repo as the source and saying to change it there. What stays is deliberate: - The tax-compliance rule is repeated rather than merely linked. It is legal exposure, and nobody should have to open another repo to find out about it. - The website-specific sweep stays, because it greps *.html and *.json where the app's greps *.swift. Its --include patterns are now quoted: unquoted, zsh glob-expands them and the command fails outright with "no matches found", so the check silently never ran. - Use the canonical host, Validate the data files, and Describe the app as it currently works are website-specific and are not shared repo material. Also records that the stored tax ID is unencrypted, not just backup files. The shared CONTENT_CONVENTIONS.md and PRODUCT_DEFINITION.md were amended first. Verified before committing: node scripts/validate-data.js passes; the CRA sweep's only hits are terms.html:72 and :91, both disclaimers — the latter sits inside a "We do not guarantee that:" list — and the canonical-host sweep finds no bare apex URLs. The v1.2.0 reference matches CHANGELOG.md:65. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to GFPriceChecker#57, which was the last checkbox of GFPriceChecker#47 — moving repo-agnostic documentation to a shared home.
That PR turned the iOS repo's
claude.mdcontent conventions into a pointer atCuWilliams/shared-docs. This repo still held its own full copy of the same rules. Left alone, the duplication that work was meant to end simply continues in the other direction — two repos each holding a full copy of a rule that is legal exposure, free to drift apart.What changed
Claude.md—## Content Conventionsgains a header naminggfpricechecker/CONTENT_CONVENTIONS.mdas the source, and pointing atPRODUCT_DEFINITION.mdfor the data model, differential arithmetic and export formats.README.md— the## Writing conventionstax rule gains a paragraph saying where it is actually decided.What deliberately stays
Not everything in that section is shared, and pushing the website-specific parts into a shared repo would be the opposite mistake:
*.htmland*.jsonwhere the app's greps*.swift. Thedata/blog.jsonstanding exception is website-only too.Use the canonical host,Validate the data files, andDescribe the app as it currently worksare about this site's build and are not shared material.Fixed along the way
--include=*.htmlunquoted gets glob-expanded, and the command fails outright withno matches foundrather than returning nothing — so a compliance check that looked like it ran had never run. Now quoted, with a comment saying why.CONTENT_CONVENTIONS.md§4 andPRODUCT_DEFINITION.md§5, amended and pushed before this PR.Verification
node scripts/validate-data.js— passes; nodata/files were touched.terms.html:72andterms.html:91. Both are disclaimers, not claims: the first states the app "does not provide tax, legal, or medical advice"; the second sits inside a "We do not guarantee that:" list, so it explicitly disclaims CRA suitability. Correct as written.v1.2.0reference added toClaude.mdmatchesCHANGELOG.md:65, which records removing exactly this class of claim on 2026-08-12.No site content changed — documentation only.
🤖 Generated with Claude Code