Repository navigation
chore(ci): fix the pip-audit gate — certifi floor and filelock CVE ignores - #486
Merged
Merged
Conversation
…nores The ci workflow's pip-audit step went red on two dependency advisories, neither caused by any code change: - certifi resolved to the vulnerable 2026.7.22 on some matrix legs (PYSEC-2026-4320, fixed in 2026.10.19). Floored to >=2026.10.19 next to the existing runtime-transitive floors so resolution is deterministic. - filelock 4.1.0 carries six CVEs whose fix (4.2.1) requires Python >=3.11, unreachable on the 3.10 legs. filelock is not an omind dependency at all — pip-audit pulls it for its own cachecontrol filecache — so the six CVE IDs are --ignore-vuln-ed in the workflow (pip-audit 2.10 has no package-level skip). Verified in a fresh venv installed exactly like CI: pip-audit exits 0. ruff check and mypy --strict clean; pytest 3956 passed with the two pre-existing test_name_timelines failures that also fail on clean main. Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Red on
ciwas thepip-auditgate, not code — two distinct dependency advisories:certifi (PYSEC-2026-4320)
Some matrix legs resolved
certifito the vulnerable 2026.7.22; the fix (2026.10.19) is on PyPI. Floored tocertifi>=2026.10.19,<2027next to the existing runtime-transitive floors (cryptography / pydantic-settings / starlette) so resolution is deterministic everywhere pip-audit looks.uv.lockrefreshed (certifi 2026.10.23).filelock (six CVEs, unfixable on the 3.10 legs)
filelockis not an omind dependency — pip-audit pulls it for its own cachecontrol filecache (omind ships its ownomind/filelock.pyshim). Its fix, 4.2.1, requires Python >=3.11, so the 3.10 matrix legs (ubuntu/windows/macos) can never install a fixed version. pip-audit 2.10 has no package-level skip, so the six CVE IDs are--ignore-vuln-ed in the workflow with the reason stated in a comment. On 3.11+ legs the ignores are no-ops (pip resolves 4.2.x there).Verification
pip install -e .[dev]):pip-auditwith the ignores exits 0 — "No known vulnerabilities found".ruff check .clean;mypy src(--strict) clean.pytest: 3956 passed; the twotest_name_timelines.py::test_preflight_names_the_ranked_note_not_a_newer_decoy[notes1-…]failures are pre-existing (reproduce identically on cleanmain) and unrelated.This unblocks #485, whose CI was red on the same audit.
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/
🤖 Generated with Claude Code