Skip to content

chore: clear lint debt + supply-chain hardening (26.09)#12

Merged
CryptoJones merged 1 commit into
mainfrom
sprint/26.09-quality-floor
May 27, 2026
Merged

chore: clear lint debt + supply-chain hardening (26.09)#12
CryptoJones merged 1 commit into
mainfrom
sprint/26.09-quality-floor

Conversation

@CryptoJones
Copy link
Copy Markdown
Owner

Summary

Post-Planning.md tightening pass — clears lint debt that 26.06's `golangci-lint` integration catches but never fixed, and pre-empts the September 2026 Node.js 20 → 24 transition on GitHub Actions before it bites.

```
$ golangci-lint run ./...
0 issues.
```

Highlights

  • 21 baseline lint findings cleared (15× errcheck on Close/Body.Close, 4× staticcheck QF1008/QF1012, 2× gocritic).
  • `cmd/console` main restructured so `os.Exit` lives in `main()` and the real work is in `run() int` — deferred cleanup now runs on every error path.
  • `renovate.json` added: weekly gomod bundle, auto-merge for GH Actions + Docker digest bumps, immediate vuln alerts.
  • `internal/tracing` test added — empty-endpoint Setup, middleware span propagation, HTTPClient transport wrapping.
  • otel semconv bumped 1.26.0 → 1.40.0 to match the SDK schema URL.
  • `FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true` in both ci.yml and release.yml — pre-empts the Sept 2026 Node.js 20 removal.

Test plan

  • `go test -race -timeout 120s ./...` clean
  • `golangci-lint run ./...` → 0 issues
  • `go vet ./...` clean
  • `gofmt -l .` clean

🤖 Generated with Claude Code

Post-Planning.md tightening pass.

- golangci-lint run ./... now passes clean. 21 baseline findings
  resolved: errcheck on Close/Body.Close (defer func() { _ = ...
  }()), staticcheck QF1008/QF1012, gocritic ifElseChain and
  exitAfterDefer in cmd/console.
- cmd/console main restructured so os.Exit lives in main() and
  the real work is in run() int — deferred cleanup now runs on
  every error path.
- renovate.json added: weekly gomod minor/patch bundle, auto-merge
  for GH Actions + Docker digest bumps, immediate vuln alerts.
- internal/tracing test added: empty-endpoint Setup, middleware
  span propagation, HTTPClient transport wrapping.
- semconv bumped 1.26.0 → 1.40.0 to match the otel SDK schema URL.
- FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true in both ci.yml and
  release.yml — pre-empts the September 2026 Node.js 20 removal
  that would otherwise hard-fail CI.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@CryptoJones CryptoJones merged commit 42669ae into main May 27, 2026
@CryptoJones CryptoJones deleted the sprint/26.09-quality-floor branch May 27, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant