Skip to content

[HS-1572480] Fix CSV upload size check #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canac merged 1 commit into from
Mar 23, 2026
Merged

[HS-1572480] Fix CSV upload size check #1657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Tool/Import/Csv/CsvUpload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const CsvUpload: React.FC<CsvUploadProps> = ({
event,
) => {
const file = event.target.files?.[0];
const maxSizeInBytes = maxSizeInMB * 1024;
const maxSizeInBytes = maxSizeInMB * 1024 * 1024;
Copy link
Copy Markdown
Contributor

@zweatshirt zweatshirt Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conversion is correct, but my concern is in uploadCsvFile.ts

There is a hard limit of 150MB and a comment that this value needs to be grabbed from the backend. Seems the work there just never got finished.

Copy link
Copy Markdown
Contributor Author

@canac canac Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it appears that there is room for improvement. But at least this change will unblock users trying to upload CSVs larger than 150KB.

Copy link
Copy Markdown
Contributor Author

@canac canac Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the limit is defined here: https://github.com/CruGlobal/mpdx_api/blob/5ae4309a4e987895cf7e87ee18631d8b2ee11a80/app/models/import.rb#L19


try {
if (!file) {
Expand Down
Loading