Merged
Conversation
kegrimes
added
the
Preview Environment
Contributor
|
Preview branch generated at https://mpdx-9339-asr-spouse-issue.d3dytjb8adxkk5.amplifyapp.com |
Contributor
Bundle sizes [mpdx-react]Compared against fde4638 No significant changes found |
dr-bizz
approved these changes
Mar 19, 2026
Contributor
dr-bizz
left a comment
dr-bizz
left a comment
There was a problem hiding this comment.
Thank you for adding this.
Can we create a test to make sure the spouse variable is passed through?
kegrimes
force-pushed
the
mpdx-9339-asr-spouse-issue
branch
from
3af4cc8 to
071135d
Compare
kegrimes
added
On Staging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When switching to the spouse's ASR, the fields were correct, however, the calculations were incorrect. They were being carried over from the user's calculations.
I realized the query was still returning the user's information instead of the spouse's. There was a call being made for the latest ASR, however, it was missing the
isSpousevariable.Testing
/reports/additionalSalaryRequestChecklist:
/pr-reviewcommand locally and fixed any relevant suggestions