MPDX-9341 - SC: Improve MHA eligibility checks to correctly handle non-existent spouse#1655
Merged
zweatshirt merged 2 commits intomainfrom Mar 20, 2026
Merged
MPDX-9341 - SC: Improve MHA eligibility checks to correctly handle non-existent spouse#1655zweatshirt merged 2 commits intomainfrom
zweatshirt merged 2 commits intomainfrom
Conversation
zweatshirt
added
the
Preview Environment
Contributor
|
Preview branch generated at https://MPDX-9341.d3dytjb8adxkk5.amplifyapp.com |
Contributor
Bundle sizes [mpdx-react]Compared against fa6e937 No significant changes found |
dr-bizz
approved these changes
Mar 19, 2026
Contributor
dr-bizz
left a comment
dr-bizz
left a comment
There was a problem hiding this comment.
I added 1 comment, but this works great
Comment on lines
+19
to
+21
| const hasSpouse = !!hcmSpouse; | ||
| const spouseEligible = | ||
| hasSpouse && (hcmSpouse.mhaEit.mhaEligibility ?? false); |
Contributor
There was a problem hiding this comment.
This is great. what are your thoughts about putting const hasSpouse = !!hcmSpouse; in the context as it might be needed elsewhere?
…ust ineligible message conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the ineligible message for spouses was being displayed for single users, since some of the checks were not ensuring that the spouse existed first.
Testing
reports/salaryCalculatorChecklist:
/pr-reviewcommand locally and fixed any relevant suggestions