Skip to content

MPDX-9331 - Show ASR comment field always, require only when over cap#1654

Open
wjames111 wants to merge 1 commit intomainfrom
MPDX-9331
Open

MPDX-9331 - Show ASR comment field always, require only when over cap#1654
wjames111 wants to merge 1 commit intomainfrom
MPDX-9331

Conversation

@wjames111
Copy link
Contributor

@wjames111 wjames111 commented Mar 18, 2026 •
edited
Loading

Description

  • Show the ASR comment (additionalInfo) field on the form at all times, not just when exceeding the salary cap
  • The field is optional by default and only required when the user's request exceeds their individual cap (existing validation unchanged)
  • Staff can use this field to communicate specific payroll needs (e.g. "Withhold an additional $200 in federal taxes from this ASR")
  • Simplified the ApprovalProcess accordion to only contain cap-related messaging (text field removed from it)
  • Related Jira: MPDX-9331

Testing

  • Go to the ASR form (New or Edit)
  • Check that the "Comments" text field is visible below Net Additional Salary
  • Submit the form without entering a comment — it should succeed (field is optional)
  • Enter an amount that exceeds your salary cap
  • Check that the Approval Process accordion still appears
  • Try to submit without a comment — validation should require it
  • Enter a comment and submit — it should succeed
  • View a submitted request and check that the Comments field is shown (read-only)

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@wjames111 wjames111 self-assigned this Mar 18, 2026
@wjames111 wjames111 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Mar 18, 2026
@wjames111 wjames111 requested a review from dr-bizz March 18, 2026 14:21
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against d2c5322

No significant changes found

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

Preview branch generated at https://MPDX-9331.d3dytjb8adxkk5.amplifyapp.com

dr-bizz
dr-bizz requested changes Mar 19, 2026
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work feels incomplete. The Approvals needed for this request section is far away from the comment textarea, so this will cause confusion.

Image

I think that we always show the src/components/Reports/AdditionalSalaryRequest/SubmitModalAccordions/ApprovalProcess/ApprovalProcess.tsx section, but change the wording to say "Optional comments"

"Use this optional comment section to communicate specific payroll needs, if needed."

@wjames111
MPDX-9331 - Always show ApprovalProcess section with optional comment…
12b369c 
…s when not over cap

Show the ApprovalProcess accordion regardless of whether the user exceeds
their salary cap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dr-bizz dr-bizz dr-bizz requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@wjames111 wjames111

Labels

On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wjames111 @dr-bizz