MPDX-9326 - 403b percentage deduction is only calculated on non 403b values

[wjames111]

Description

On ASR, the 7% 403b Contribution is taking 7% out of the amount just fine, but it is also taking the 7% out of "403(b) Contribution - Roth" and prob Tranditional as well, which it shouldn't be.

See the screenshots, the 7% contribution to the 403 should be $1,400, but it's not, as it's adding 7% of the $10,000 in the 403b.

Issue outlined in thread here.

Jira ticket available here.

Testing

• Go to ASR Page
• Add a 403b contribution in the main form
• Check the deduct 7% 403b checkbox below the main form
• Make sure it only equals 7% of the non 403b values

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
• I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
• I have requested a review from another person on the project
• I have tested my changes in preview or in staging
• I have cleaned up my commit history

[github-actions]

Bundle sizes [mpdx-react]

Compared against d2c5322

No significant changes found

[github-actions]

Preview branch generated at https://MPDX-9326.d3dytjb8adxkk5.amplifyapp.com

[dr-bizz]

Something else we found was incorrect is the calculation on the 2nd checkbox, where users can take their normal percentage of 403(b) out of their ASR and contribute it to their Roth 403(b).

The calculation should be the total request minus any contributions the user made to their 403 (b). And then their normal percentage of 403(b) of that, otherwise you are taking that percentage out of what you are adding to the 403B back into the 403B.

Can we also make sure the percentage calculation is correct?

[wjames111]

@dr-bizz I updated The Roth 403(b) percentage deduction to now deduct the calculatedTraditionalDeduction before applying the roth403bPercentage.

(totalWithout403b - calculatedTraditionalDeduction) * roth403bPercentage

[dr-bizz]

This works great! Thank you for making these changes.

Can you remove Claude as a co-author on commits?
This just reinforces that the dev should know and understand each line and shouldn't blame Claude.

Upon doing so, you can merge