Skip to content

Update Tool Details to use Circuit to launch the tips tutorial#4337

Draft
frett wants to merge 5 commits intodevelopfrom
toolDetailsTipsTutorial
Draft

Update Tool Details to use Circuit to launch the tips tutorial#4337
frett wants to merge 5 commits intodevelopfrom
toolDetailsTipsTutorial

Conversation

@frett
Copy link
Contributor

@frett frett commented Feb 27, 2026

  • s/State/UiState
  • s/Event/UiEvent
  • create an openTool method to share logic when opening training tips
  • don't route changing variants through the ui eventSink
  • move the eventSink to be defined on the UiState object directly

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 66.07143% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.73%. Comparing base (a0a13b5) to head (7433e08).

Files with missing lines Patch % Lines
...ru/godtools/ui/tooldetails/ToolDetailsPresenter.kt 70.27% 1 Missing and 10 partials ⚠️
...g/cru/godtools/ui/tooldetails/ToolDetailsLayout.kt 40.00% 1 Missing and 5 partials ⚠️
...rg/cru/godtools/ui/tooldetails/ToolDetailsAbout.kt 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4337      +/-   ##
===========================================
- Coverage    49.75%   49.73%   -0.02%     
===========================================
  Files          440      440              
  Lines        11882    11882              
  Branches      2069     2070       +1     
===========================================
- Hits          5912     5910       -2     
  Misses        5357     5357              
- Partials       613      615       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frett frett force-pushed the toolDetailsTipsTutorial branch from 58d705b to 7433e08 Compare March 11, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant