Skip to content

Add Detail Widget as plugin#690

Open
Joshua-ChiangMai wants to merge 15 commits intomasterfrom
jb/testPluginDetail
Open

Add Detail Widget as plugin#690
Joshua-ChiangMai wants to merge 15 commits intomasterfrom
jb/testPluginDetail

Conversation

@Joshua-ChiangMai
Copy link

@Joshua-ChiangMai Joshua-ChiangMai commented Feb 12, 2026

migrate Detail Widget as plugin

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

Please add one release label:
major (for breaking changes), minor (for new features), patch (for bug fixes) or skip-release (to skip the auto release process).

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026 •
edited
Loading

Lighthouse Performance Report

Metrics





📄Full Report
Note: Above values are an average of 3 reports, only the last report was uploaded.

@Joshua-ChiangMai Joshua-ChiangMai added the patch Tag Pull Requests to trigger a patch version update label Feb 12, 2026
@johnny-hausman johnny-hausman self-requested a review February 13, 2026 03:19
johnny-hausman
johnny-hausman requested changes Feb 13, 2026
View reviewed changes
Copy link
Collaborator

@johnny-hausman johnny-hausman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have made some changes to your plugin code. Let me know if you have any additional questions

@Joshua-ChiangMai Joshua-ChiangMai force-pushed the jb/testPluginDetail branch 3 times, most recently from 7ada954 to af57c65 Compare February 14, 2026 13:44
johnny-hausman
johnny-hausman approved these changes Feb 16, 2026
View reviewed changes
Copy link
Collaborator

@johnny-hausman johnny-hausman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good!

Have we fixed the display issues you were worried about?

@Joshua-ChiangMai
Copy link
Author

Joshua-ChiangMai commented Mar 3, 2026

These look good!

Have we fixed the display issues you were worried about?

I have fixed it(see screenshot). image

@johnny-hausman
Copy link
Collaborator

johnny-hausman commented Mar 5, 2026

It still looks like we are not passing our tests. Have you run the tests locally and seen where the tests are failing? I have a feeling it is related to how the elements are being looked up.

Widget Tests -- DataCollection -- DataCollection Tests (failed) (attempt 2)

@Joshua-ChiangMai
Copy link
Author

Joshua-ChiangMai commented Mar 7, 2026

It still looks like we are not passing our tests. Have you run the tests locally and seen where the tests are failing? I have a feeling it is related to how the elements are being looked up.

Widget Tests -- DataCollection -- DataCollection Tests (failed) (attempt 2)

I tested the functionality manually in the web app locally, but I haven’t run the e2e tests yet. I’ll run them today and see what’s causing the failures. Thanks.

@Joshua-ChiangMai Joshua-ChiangMai force-pushed the jb/testPluginDetail branch 3 times, most recently from 2671743 to dbc799d Compare March 10, 2026 16:05
johnny-hausman
johnny-hausman requested changes Mar 17, 2026
View reviewed changes
Copy link
Collaborator

@johnny-hausman johnny-hausman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's start with this first change to see how that effects things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnny-hausman johnny-hausman johnny-hausman requested changes

Assignees

No one assigned

Labels

patch Tag Pull Requests to trigger a patch version update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Joshua-ChiangMai @johnny-hausman