Repository navigation
Produce encoded CRT offsets from actual current child coordinates - #5053
Merged
Mister-Meeseeks merged 2 commits intoOct 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual balanced CRT caller reconstructs a left integer from current transformed child coordinates. Existing encoded triangular offsets use original lower coordinates, and the fixed key port consumes supplied ROM data. This adds the missing encoded current-child numerical producer and completes its right-node offset/padded-coordinate consumer.
Concrete source witness: moduli
(5,7)and current coordinates(1,5)reconstruct11; right modulus13gets offset7. Treating those coordinates as original mixed-radix digits yields26and wrong offset0, despite both being individually valid.The new
Arithmeticexplicitly admits any modulus1<M<2^(P-1)in a common P-bit arena and implements modular operations from retained unsigned bit-tape primitives. It does not call or bypass the frozenRingconstructor, whose stricter significant-bit guard remains unchanged and tested. No runtime integer decoding, word-backing read, bit_length or times_small(decoded modulus) is used.The written proof covers arbitrary finite nonempty left/right groups with pairwise coprime moduli and complete product below
2^(P-1). It proves locally scaled reconstruction, all successive right prefixes, invalid-left disabling, preservation of padded right coordinates, borrowed byte/head preservation and complete owned cleanup. At most 32 numerical slots are live in a fixed 64-slot arena; a conservative2^20*(P+2)^4bound counts source-tape/control operations. This is not unconditionally substituted for a complete literal binary E(p,ell) implementation.Validation (CPython 3.12, standard library):
(4,4,4,5). Each module receives an encoded source-derived fixture; this is not an uninterrupted physical whole-tree execution.Canonical coordination: #4709 (comment) . Card
uniform-transfer-audit, refined to the actual current-child numeric boundary. Scientific basef259dabc7d70e0db8d6d36bfda888f008bbfecc1, priority revision 7. Initial overlap covered all 6710 notes, 320 open PR bodies and 4130 Discussion records with complete inventory/pagination; arbitrary diffs and unpublished work remain limits.Family decision: narrow to this complete local numerical module, then stop. Initialized arena/parameter/descriptor production and transport, literal binary control compilation, complete ROM/Beneš construction, raw macro, sparse repair, ordinary interchanges, full E and native/outer transfer remain external. No supplier, selected frontier, complete multiplication theorem, speedup or new kappa is claimed. README/TASK preserve bounded next questions.
Credit Cinna Davis/#4100; Hiroki KUMAZAKI/#4169/#4174 and the mixed-width caller; Tekalign's already encoded original-coordinate triangular offset producer; ToikY/#4192, unpaidmoon/#4377; Jose Manuel and the retained physical Word/caller, Douglas Colkitt/John-Michael Smith and NOTICE lineage. Frozen sources are unchanged. Prepared by JoyboyBrian with substantial OpenAI Codex assistance; Apache-2.0. Independent human and formal proof-kernel acceptance are unclaimed.
Submission refresh: canonical main
4c0a359d88f22f05189d51f48387750b801a45d4; governing guidance, selected record and this contribution's source inputs remain unchanged from the scientific base. Fresh overlap covers 309 open PR bodies, 4,156 Discussion records and all 6,760 local notes with complete reported pagination/inventory. New public deltas were checked; this remains advisory text coverage, excluding arbitrary diffs and unpublished work.