Repository navigation
Show MAC addresses and manufacturers in every build (engine v1.7.0) - #1
Merged
Merged
Conversation
macOS 27 hides the ARP table from children of an ad-hoc signed app but not from the app itself, so Debug builds showed no MAC addresses, manufacturers or ARP-found hosts. Discovery now runs ns with --neighbor-table=parent and answers each neighbors_request on its stdin with the table read in-process (a Swift port of the engine's macos_dump). The engine keeps all logic of what an entry means. Needs the engine release that adds --neighbor-table; until it is pinned, test with fetch-engine.sh --local.
v1.7.0 is the first engine release with --neighbor-table=parent, which discovery now passes, so pin it (and its release asset checksums).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
macOS 27 hides the ARP table from children of an app that is not Developer ID signed, so ad-hoc and Apple Development builds showed no MAC addresses, manufacturers or ARP-found quiet hosts. The app's own process can still read the table.
What
nswith--neighbor-table=parent. Eachneighbors_requestthe engine prints is answered on its stdin, fromEngineRun's stdout handler (off the main actor), with the table read in-process byNeighborTable.read(). That is a Swift port of the engine'smacos_dump; the engine keeps all logic of what an entry means (feat: let the parent app supply the ARP table (--neighbor-table=parent) NetScanner#83).macos-arm64.zip/macos-x86_64.zipchecksums.Testing
Scripts/fetch-engine.sh --forcedownloads and verifies the v1.7.0 assets (universalns,--versionv1.7.0).swift test: 47 tests in 13 suites pass, including newNeighborTableand reply-encoding tests.xcodebuildsucceeds with no compiler warnings.