Extract shared telephony/omnichannel foundation ahead of Contact Center - #533
Open
MikeAlhayek wants to merge 3 commits into
Open
Extract shared telephony/omnichannel foundation ahead of Contact Center#533MikeAlhayek wants to merge 3 commits into
MikeAlhayek wants to merge 3 commits into
Conversation
Lands the pre-existing-module changes that the upcoming Contact Center work depends on into main, so that when the Contact Center branch merges after the v2 release it introduces no breaking changes to shared modules. Scope (Option A - cleanly separable shared changes only): - Moves the modified shared files across Telephony(.Abstractions), DialPad, Omnichannel(.Core/.Sms/.Managements), AI(.Core/.Chat/.DataSources), PhoneNumbers.Verifications, and their tests. - Adds the additive Telephony.Abstractions provider-capability contracts and models required by the moved interfaces (call control/state, inbound, hold, mute, DTMF, transfer, conference, voicemail, directory, audio, recording media, provider identity, incoming-call context). - Splits the telephony provider settings screen into a dedicated "Telephony Administration" feature so the core services/hub can run headless. - Re-groups Telephony and DialPad under a "Telephony" feature category. Excludes the Contact Center orchestration layer and the additive Telephony.Core/Asterisk/ContactCenter projects, which remain on the Contact Center branch (they are new and additive, so they cannot break existing v2 consumers). Surgery on Telephony/DialPad Startup and csproj files drops the Telephony.Core/ContactCenter.Abstractions references while keeping the shared package/project references the moved files need. Validated: solution builds with -warnaserror (0 warnings), 1606 tests pass, assets rebuild with no drift, and the documentation site builds with no broken links. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
Creating or editing an omnichannel campaign group threw "InvalidOperationException: The shape type 'OmnichannelCampaignGroup_Edit' is not found for the theme 'TheAdmin'". The IDisplayManager<OmnichannelCampaignGroup> builds a root editor shape named "OmnichannelCampaignGroup_Edit", but the module only shipped the field editor template (OmnichannelCampaignGroupFields.Edit.cshtml) and was missing the root editor view. Add OmnichannelCampaignGroup.Edit.cshtml rendering the editor's Content zone, mirroring the other omnichannel catalog editors (Campaign, Disposition, ChannelEndpoint). Document the fix in the v2.0.0 changelog. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the pre-existing-module changes that the upcoming Contact Center work depends on into main, so that when the Contact Center branch merges after the v2 release it introduces no breaking changes to shared modules.
Scope (Option A - cleanly separable shared changes only):
Excludes the Contact Center orchestration layer and the additive Telephony.Core/Asterisk/ContactCenter projects, which remain on the Contact Center branch (they are new and additive, so they cannot break existing v2 consumers).
Surgery on Telephony/DialPad Startup and csproj files drops the Telephony.Core/ContactCenter.Abstractions references while keeping the shared package/project references the moved files need.
Validated: solution builds with -warnaserror (0 warnings), 1606 tests pass, assets rebuild with no drift, and the documentation site builds with no broken links.