Merged
Conversation
- CONTRIBUTING.md with build, test, style guide, PR process - CHANGELOG.md for v0.1.0 (unreleased) - Issue templates: bug report and feature request - Godoc comments on all exported types and functions
Remove unused middle 'options' slot from struct tag parser. Tags are now mmap:"name,64" instead of mmap:"name,,64".
Add WithOneWriter() and WithReadOnly() functional options for CreateStore and OpenStore. WithOneWriter acquires an exclusive flock on a sidecar .lock file, ensuring only one writer process at a time. WithReadOnly maps the file with PROT_READ only, skips seqlock recovery, skips flush/sync on Close, and rejects all write operations. - Add StoreOption type, WithReadOnly(), WithOneWriter() (options.go) - Add flockExclusive/funlock helpers (lock_unix.go) - Add ErrLocked sentinel error (errors.go) - Guard SeqBeginWrite on read-only stores (store_seq.go) - Update codegen template to pass opts through (store.tmpl) - Regenerate example/marketcap_store.go - Fix Store.writable field bug in OpenStore (was hardcoded to true) - Fix struct field alignment in Store - Add 100% test coverage for all new code - Add read-only and one-writer benchmarks Closes #14 Closes #15
Codecov Report✅ All modified and coverable lines are covered by tests.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.