Skip to content

Refactor/code review fixes#20

Merged
CreditWorthy merged 7 commits intomainfrom
refactor/code-review-fixes
Feb 21, 2026
Merged

Refactor/code review fixes#20
CreditWorthy merged 7 commits intomainfrom
refactor/code-review-fixes

Conversation

@CreditWorthy
Copy link
Owner

No description provided.

…efaultMaxVA, G115 docs

- Append: replace CAS (ignored return) with Store under mutex
- Grow check: > to >= fixes off-by-one at exact capacity boundary
- Extract header offsets as named constants (offsetRecordCount, offsetCapacity)
- Raise DefaultMaxVA from 8 bytes to 1 GB with documentation
- Document gosec G115 avoidance in WriteString/WriteBytes length prefix casts
- Fix TestAppend_GrowFails to match corrected >= threshold
If a Region is garbage collected without Close(), a warning is printed
to stderr and the mapping is cleaned up. The finalizer is cleared on
Close() to avoid false positives.
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
mmap_unix.go 100.00% <100.00%> (ø)
store.go 100.00% <100.00%> (ø)
store_seq.go 100.00% <ø> (ø)
store_write.go 100.00% <ø> (ø)

@CreditWorthy CreditWorthy merged commit 2063061 into main Feb 21, 2026
2 checks passed
@CreditWorthy CreditWorthy deleted the refactor/code-review-fixes branch February 21, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant