a11y: skip-to-main link in layout shell (#34) - #44
Conversation
Mirror Create-Python-App layout: first focusable skip link targets #main-content wrapped around page children.
|
@KhyFee is attempting to deploy a commit to the create-node-app Team on Vercel. A member of the Team first needs to authorize it. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Same shell pattern as Create-Python-App/website#25 — uses existing |
|
Vercel auth pending on fork preview — logic-only change mirroring merged Create-Python-App pattern. Happy to rebase if shell layout shifts on main. |
|
Hi @KhyFee — CI failing/conflict, please rebase. |
|
Thanks for picking this up! The skip link styling looks good. One blocker before we can merge: wrapping Could you rework it to one of these instead?
Option 2 is the one we'd prefer long-term — a single landmark owned by the shell keeps every page honest. |
|
Thanks @ulises-jeremias — good catch on nested Went with option 2: shell keeps the single Branch is updated — please take another look when you can. |
Keep skip link + <main id="main-content"> in the shell; replace page-level <main> wrappers with <div> so routes no longer nest landmarks.
|
Thanks for merging #44, @ulises-jeremias — and for the nested |
Summary
LayoutShell<main id="main-content">(matches Create-Python-App docs: website README uplift + catalog sync (closes #23 #24) #25)Closes #34
Test plan