Skip to content

a11y: labels for theme toggle, search, category chips #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulises-jeremias merged 2 commits into from
Aug 17, 2026
Merged

a11y: labels for theme toggle, search, category chips #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfae278
a11y: labels for theme toggle, search, category chips
KhyFee Aug 5, 2026
58b2cf8
fix(a11y): add type and aria-pressed on template category chips
KhyFee Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/app/extensions/ExtensionsPageClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,9 @@ export function ExtensionsPageClient() {
<div className="mx-auto max-w-5xl py-8 fade-in-up-delay-1">
<div className="flex gap-2 overflow-x-auto pb-1 scrollbar-hide mb-4">
<button
type="button"
onClick={() => setSelectedCategory('')}
aria-pressed={selectedCategory === ''}
className={cn(
'shrink-0 rounded-full px-3 py-1 text-xs font-medium transition-colors',
selectedCategory === ''
Expand All @@ -136,8 +138,10 @@ export function ExtensionsPageClient() {
</button>
{extensionCategories.map((cat) => (
<button
type="button"
key={cat}
onClick={() => setSelectedCategory(cat)}
aria-pressed={selectedCategory === cat}
className={cn(
'shrink-0 rounded-full px-3 py-1 text-xs font-medium transition-colors',
selectedCategory === cat
Expand All @@ -155,6 +159,7 @@ export function ExtensionsPageClient() {
<Input
type="search"
placeholder="Search extensions..."
aria-label="Search extensions"
className="w-full bg-background/50 backdrop-blur-sm pl-8 border-cyan-500/20 focus:border-cyan-500/40 transition-all duration-300"
value={searchQuery}
onChange={handleSearchChange}
Expand Down
5 changes: 5 additions & 0 deletions src/app/templates/TemplatesPageClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ export function TemplatesPageClient() {
<div className="mx-auto max-w-5xl py-4 fade-in-up-delay-1">
<div className="flex gap-2 overflow-x-auto pb-1 scrollbar-hide mb-4">
<button
type="button"
onClick={() => setSelectedCategory('')}
aria-pressed={selectedCategory === ''}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
className={cn(
'shrink-0 rounded-full px-3 py-1 text-xs font-medium transition-colors',
selectedCategory === ''
Expand All @@ -120,8 +122,10 @@ export function TemplatesPageClient() {
</button>
{categories.map((cat) => (
<button
type="button"
key={cat.slug}
onClick={() => setSelectedCategory(cat.slug)}
aria-pressed={selectedCategory === cat.slug}
className={cn(
'shrink-0 rounded-full px-3 py-1 text-xs font-medium transition-colors',
selectedCategory === cat.slug
Expand All @@ -139,6 +143,7 @@ export function TemplatesPageClient() {
<Input
type="search"
placeholder="Search templates..."
aria-label="Search templates"
className="w-full bg-background/50 backdrop-blur-sm pl-8 border-primary/20 focus:border-primary/40 transition-all duration-300"
value={searchQuery}
onChange={handleSearchChange}
Expand Down
14 changes: 11 additions & 3 deletions src/components/theme-toggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,17 @@ export function ThemeToggle() {
return (
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button variant="ghost" size="icon" className="relative h-9 w-9 rounded-full">
<Sun className="h-5 w-5 rotate-0 scale-100 transition-all dark:-rotate-90 dark:scale-0" />
<Moon className="absolute h-5 w-5 rotate-90 scale-0 transition-all dark:rotate-0 dark:scale-100" />
<Button
variant="ghost"
size="icon"
className="relative h-9 w-9 rounded-full"
aria-label="Toggle theme"
>
<Sun className="h-5 w-5 rotate-0 scale-100 transition-all dark:-rotate-90 dark:scale-0" aria-hidden="true" />
<Moon
className="absolute h-5 w-5 rotate-90 scale-0 transition-all dark:rotate-0 dark:scale-100"
aria-hidden="true"
/>
<span className="sr-only">Toggle theme</span>
</Button>
</DropdownMenuTrigger>
Expand Down