Make run_gettext.sh executable (fixes Linux -s build) - #584
Open
lolli42 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Linux,
./BuildLinux.sh -saborts at the translations step with:Cause
BuildLinux.shhas invoked./run_gettext.shdirectly sincerelease-v6.0.2 (de4c5e5), but
run_gettext.shis committednon-executable (mode
100644). On a fresh clone the script isn'trunnable, and with
set -ethe build stops there before producing thebinary/AppImage.
Fix
Set the executable bit on
run_gettext.sh(100644→100755).Testing
Fresh clone on Linux Mint 22.3 (Ubuntu 24.04 base, GCC 13): the
-sbuild previously stopped at
run_gettext.sh; with the exec bit set itruns and the build completes through packaging.