Add observer in-flight state and partition recovery on subscribe#3334
Add observer in-flight state and partition recovery on subscribe#3334woksin wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Cratis Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 3c05946 | Previous: 9c41e1c | Ratio |
|---|---|---|---|
Cratis.Chronicle.Benchmarks.AppendManyBenchmark.AppendManyEvents(EventCount: 100) |
171390925.93333334 ns (± 27503433.776370574) |
68128824.7 ns (± 7671149.609764319) |
2.52 |
Cratis.Chronicle.Benchmarks.AppendManyBenchmark.AppendManyEvents(EventCount: 1000) |
987148769.1 ns (± 125488433.40735982) |
587439487.4 ns (± 115163188.51672608) |
1.68 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @einari
|
@copilot rebase on main and fix conflicts |
Done in |
|
@copilot Fix integration tests |
|
@copilot There are regressions - broken specs. Rebase on top of origin/main and fix any conflicts and then handle broken specs. |
3c05946 to
ea6a19d
Compare
The branch has been rebased onto The integration test |
Added
CatchingUpInFlightstate machine state on observer subscribe that re-handles any partitions left in-flight by a previous server crash before transitioning toRouting(Improve state consistency around observers and next/handled event sequence number for when multiple partitions are working and for some reason the server goes down #1682)Changed
Observer.SubscribeandObserver.SubscribeToAllEventsnow transition throughCatchingUpInFlightbefore enteringRouting, recovering any partitions that were in-flight at the time of a previous server crash (Improve state consistency around observers and next/handled event sequence number for when multiple partitions are working and for some reason the server goes down #1682)Disconnected,Observing, andReplaystates now allow transition toCatchingUpInFlight(Improve state consistency around observers and next/handled event sequence number for when multiple partitions are working and for some reason the server goes down #1682)