Skip to content

Add observer in-flight state and partition recovery on subscribe#3334

Open
woksin wants to merge 1 commit into
mainfrom
issue-1682-observer-state-recovery
Open

Add observer in-flight state and partition recovery on subscribe#3334
woksin wants to merge 1 commit into
mainfrom
issue-1682-observer-state-recovery

Conversation

@woksin
Copy link
Copy Markdown
Contributor

@woksin woksin commented May 27, 2026

Added

Changed

Comment thread Source/Kernel/Core/Observation/States/CatchingUpInFlight.cs Dismissed
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Cratis Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 3c05946 Previous: 9c41e1c Ratio
Cratis.Chronicle.Benchmarks.AppendManyBenchmark.AppendManyEvents(EventCount: 100) 171390925.93333334 ns (± 27503433.776370574) 68128824.7 ns (± 7671149.609764319) 2.52
Cratis.Chronicle.Benchmarks.AppendManyBenchmark.AppendManyEvents(EventCount: 1000) 987148769.1 ns (± 125488433.40735982) 587439487.4 ns (± 115163188.51672608) 1.68

This comment was automatically generated by workflow using github-action-benchmark.

CC: @einari

@einari einari added the wait for consolidation Once tagged with this, it means we want to consolidate it with something else. label May 29, 2026
@woksin woksin marked this pull request as ready for review May 29, 2026 13:06
@woksin
Copy link
Copy Markdown
Contributor Author

woksin commented May 29, 2026

@copilot rebase on main and fix conflicts

Copy link
Copy Markdown
Contributor

Copilot AI commented May 29, 2026

@copilot rebase on main and fix conflicts

Done in 3c05946. I rebased the branch onto main, reconciled branch history so it could be pushed, and validated with targeted observer/observation specs.

Copilot finished work on behalf of woksin May 29, 2026 13:14
@woksin
Copy link
Copy Markdown
Contributor Author

woksin commented May 31, 2026

@copilot Fix integration tests

@einari
Copy link
Copy Markdown
Contributor

einari commented Jun 1, 2026

@copilot There are regressions - broken specs. Rebase on top of origin/main and fix any conflicts and then handle broken specs.

Copilot AI force-pushed the issue-1682-observer-state-recovery branch from 3c05946 to ea6a19d Compare June 1, 2026 17:11
Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 1, 2026

@copilot There are regressions - broken specs. Rebase on top of origin/main and fix any conflicts and then handle broken specs.

The branch has been rebased onto origin/main (commit ea6a19dff) and all merge conflicts resolved. Core.Specs pass (1458 tests).

The integration test and_reactors_coordinate_tenant_outbox_forwarding (8 failures — WaitTillSubscribed timeout) is a regression from our change of TransitionTo<Routing>()TransitionTo<CatchingUpInFlight>() in Observer.Subscribe(). Root cause investigation traced the full state machine cascade (CatchingUpInFlight → Routing → Observing); the logic appears correct but the IsSubscribed check in WaitTillSubscribed times out, meaning either the cascade is silently failing or Subscribe() is not completing. A fix was not reached within the allotted time — continued investigation is needed into whether the CanTransitionTo guard or an unhandled exception in the MongoDB GetFor() call is silently aborting the transition chain.

Copilot finished work on behalf of einari June 1, 2026 17:12
Copilot AI requested a review from einari June 1, 2026 17:12
einari added a commit that referenced this pull request Jun 2, 2026
…s-3338-3335-3334-3333-3331

Consolidate PRs #3338, #3335, #3334, #3333, #3331, and #3326 into one release slice with regression follow-ups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wait for consolidation Once tagged with this, it means we want to consolidate it with something else.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants