Support src.cpp and src.c in the same rules dir#92
Merged
Conversation
nunoplopes
reviewed
May 13, 2026
| llvm::json::Object file_root; | ||
| cpp2rust::Extract(path, file_root); | ||
| for (auto &[k, v] : file_root) { | ||
| if (root.find(k) != root.end()) { |
Contributor
There was a problem hiding this comment.
!root.try_emplace(k, v).second
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For C string functions, C++ defines const overloads. For example, in C, strchr is defined as:
In C++, it's overloaded as:
Writing
char *f5(const char *a0, int a1) { return strchr(a0, a1); }would result in the following error:For this reason, parse both
src.cppandsrc.cin a rules dir.src.ckeeps C specific rules andsrc.cppkeeps C++ specific rules. The function names in the 2 functions cannot collide, cpp-rule-preprocessor checks against colliding names.