Add dummy definition for referenced but never-defined structs#143
Open
lucic71 wants to merge 4 commits into
Open
Add dummy definition for referenced but never-defined structs#143lucic71 wants to merge 4 commits into
lucic71 wants to merge 4 commits into
Conversation
Contributor
Author
|
#[repr(C)]
pub struct opaque {
_opaque: [u8; 0],
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles opaque pointers to user defined forward declared structs. It's allowed to use such pointers, even though the struct is not defined in any translation unit.
To implement this, I modified record_decls_ to also keep an extra bool with the following meaning:
At the end of visiting all TU's, for the record_decls_ that are only referenced (not defined), a dummy struct definition is generated: