Fix as never test casts and add --page-name whitespace normalization - #4
Merged
Merged
Conversation
Co-authored-by: jfallaire <7849359+jfallaire@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add commerce troubleshoot deploy command
Fix Mar 4, 2026
as never test casts and add --page-name whitespace normalization
jfallaire
marked this pull request as ready for review
March 4, 2026 21:51
jfallaire
added a commit
that referenced
this pull request
Mar 4, 2026
* Add troubleshoot deploy docs * Align release workflow with trusted * Fix `as never` test casts and add `--page-name` whitespace normalization (#4) * Initial plan * Fix as never casts in tests and normalize pageName flag Co-authored-by: jfallaire <7849359+jfallaire@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jfallaire <7849359+jfallaire@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: jfallaire <7849359+jfallaire@users.noreply.github.com>
jfallaire
added a commit
that referenced
this pull request
Mar 4, 2026
…ws (#5) * Add troubleshoot deploy docs * Align release workflow with trusted * Fix `as never` test casts and add `--page-name` whitespace normalization (#4) * Initial plan * Fix as never casts in tests and normalize pageName flag Co-authored-by: jfallaire <7849359+jfallaire@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jfallaire <7849359+jfallaire@users.noreply.github.com> * chore: bump plugin version to 0.7.0 --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: jfallaire <7849359+jfallaire@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three issues flagged in code review on the
org:commerce:troubleshoot:deploycommand:as never, defeating TypeScript's structural checks on mockConfigurationobjects.--page-namewas forwarded raw to the deployer without trimming, allowing whitespace-only values through despite the flag being required.Changes
Configurationtype and replaceas neverwithas Configurationon both config stub callsites — compiler now catches mock/shape drift.flags.pageNamethroughreadString()(trims + returnsundefinedfor blank) and add athis.error()guard, consistent with howorganizationIdandaccessTokenare already validated:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.