Skip to content

feat: add skills auto-discovery configuration#533

Merged
rwmjhb merged 1 commit intoCortexReach:masterfrom
Tony-ooo:feat/auto-discover-skills
Apr 6, 2026
Merged

feat: add skills auto-discovery configuration#533
rwmjhb merged 1 commit intoCortexReach:masterfrom
Tony-ooo:feat/auto-discover-skills

Conversation

@Tony-ooo
Copy link
Copy Markdown
Contributor

@Tony-ooo Tony-ooo commented Apr 5, 2026

Summary

This PR adds support for OpenClaw to automatically discover skills in the plugin directory.

Changes

  1. openclaw.plugin.json: Added "skills": ["./skills"] configuration field

    • Enables OpenClaw to automatically discover and load skills from the plugin's skills directory
    • Follows the OpenClaw plugin specification for skill discovery
  2. skills/lesson/SKILL.md: Added metadata configuration dependency declaration

    • Declares dependency on plugins.entries.memory-lancedb-pro.enabled config
    • Ensures the skill only runs when the plugin is enabled

Motivation

Currently, OpenClaw requires manual skill registration. This change enables automatic skill discovery from the plugin directory, simplifying plugin development and maintenance.

Testing

  • Tested with OpenClaw workspace plugin loading
  • Verified skills are automatically discovered and loaded
  • Confirmed lesson skill works correctly with config dependency

Related

  • Plugin type: memory
  • Version: 1.1.0-beta.10

@win4r
Copy link
Copy Markdown
Collaborator

win4r commented Apr 6, 2026

@claude

@claude
Copy link
Copy Markdown

claude bot commented Apr 6, 2026

Claude Code is working…

I'll analyze this and get back to you.

View job run

@rwmjhb
Copy link
Copy Markdown
Collaborator

rwmjhb commented Apr 6, 2026

Review Summary

Verdict: APPROVE | Value: 43% | Size: TRIVIAL

What This PR Does

Adds an auto-discovery config field (skills) so OpenClaw skills are automatically found from the plugin directory, removing the need for manual registration.

Must Fix

  • Build failure (stale base): The branch has diverged from main. Please rebase onto main and confirm the build passes — the failure appears pre-existing on the base, not introduced by this PR.

Questions for Author

  1. Has this auto-discovery pattern been tested in any other OpenClaw plugin, or is this the first implementation?
  2. What happens when plugins.entries.memory-lancedb-pro.enabled is absent or false — does the skill silently no-op, error, or behave normally?

Bottom Line

Code looks good. Rebase to resolve stale-base build failure, then this is ready to merge.


Automated review — 4 rounds | Primary: claude

Copy link
Copy Markdown
Collaborator

@AliceLJY AliceLJY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: feat: add skills auto-discovery configuration

Verdict: Approve

What I checked

  1. Backward compatibility — Adding "skills": ["./skills"] to openclaw.plugin.json is additive. The skills/ directory already exists on main with the lesson skill. Previously skills had to be registered manually; this enables automatic discovery.

  2. Schema correctness — The "skills" field is placed at the top level of the plugin manifest (alongside id, name, kind, etc.), which is the correct location per the OpenClaw plugin specification. The value ["./skills"] is a relative path array pointing to the existing directory.

  3. SKILL.md metadata — The added metadata: { "openclaw": { "requires": { "config": ["plugins.entries.memory-lancedb-pro.enabled"] } } } in skills/lesson/SKILL.md declares a config dependency so the skill only loads when the plugin is enabled. This is a sensible guard that prevents the skill from appearing in contexts where the memory plugin isn't active.

  4. Risk assessment — 2 lines changed across 2 files, both config/metadata only, no logic code touched. Very low risk.

  5. CI — cli-smoke pass, version-sync pass.

LGTM. Clean, minimal change that enables proper skill auto-discovery.

Add 'skills' field to openclaw.plugin.json to enable OpenClaw automatically discover skills in plugin directory

- openclaw.plugin.json: add "skills": ["./skills"] configuration
- skills/lesson/SKILL.md: add metadata config dependency declaration
@Tony-ooo Tony-ooo force-pushed the feat/auto-discover-skills branch 2 times, most recently from 95a6a4f to 4c087dd Compare April 6, 2026 12:59
@rwmjhb rwmjhb merged commit 1c7c0e4 into CortexReach:master Apr 6, 2026
@Tony-ooo Tony-ooo deleted the feat/auto-discover-skills branch April 7, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants