fix(marketplace): add input validation guards to list_asset - #54
Merged
vestor-dev merged 2 commits intoJul 25, 2026
Merged
Conversation
vestor-dev
requested changes
Jul 18, 2026
vestor-dev
left a comment
vestor-dev
left a comment
Collaborator
There was a problem hiding this comment.
pls delete the cargo.lock file @MissHarah
Collaborator
|
@MissHarah any update ?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List_asset accepted any price, name, or description without checking them. This PR adds four guards before any storage is touched: price must be greater than zero (InvalidPrice), name must be 1–200 bytes (InvalidMetadata), description must be 1–2000 bytes (InvalidMetadata), and the total listing count must not exceed MAX_ASSETS of 10,000 (AssetLimitReached). The return type changes from u64 to Result<u64, MarketplaceError>. 11 boundary tests are added covering exact-limit and one-over-limit cases for every guard.
Closes #19