Skip to content

27 chorecmake replace deprecated fetchcontent populate calls #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SizzleUnrlsd merged 5 commits into from
Mar 27, 2026
Merged

27 chorecmake replace deprecated fetchcontent populate calls #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b711242
build(cmake): require CMake 3.28 for modern FetchContent usage
SizzleUnrlsd Mar 26, 2026
5392cd5
build(deps): migrate nlohmann_json fetch flow to MakeAvailable
SizzleUnrlsd Mar 26, 2026
0b65dc6
build(deps): migrate cpp-httplib fetch flow to MakeAvailable
SizzleUnrlsd Mar 26, 2026
978f19d
build(deps): migrate coretrace logger fetch flow to MakeAvailable
SizzleUnrlsd Mar 26, 2026
9ecc49b
build(deps): migrate stack analyzer fetch flow to MakeAvailable
SizzleUnrlsd Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.21)
cmake_minimum_required(VERSION 3.28)

project(ArgumentManagerProject VERSION 1.0 LANGUAGES CXX)

Expand Down
7 changes: 2 additions & 5 deletions cmake/FetchNlohmannJson.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ FetchContent_Declare(
json
URL https://github.com/nlohmann/json/releases/download/v3.11.3/json.tar.xz
DOWNLOAD_EXTRACT_TIMESTAMP FALSE
EXCLUDE_FROM_ALL
)

FetchContent_GetProperties(json)
if(NOT json_POPULATED)
FetchContent_Populate(json)
add_subdirectory(${json_SOURCE_DIR} ${json_BINARY_DIR} EXCLUDE_FROM_ALL)
endif()
FetchContent_MakeAvailable(json)
7 changes: 2 additions & 5 deletions cmake/httpLib.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ FetchContent_Declare(
cpp_httplib
GIT_REPOSITORY https://github.com/yhirose/cpp-httplib.git
GIT_TAG v0.14.3
EXCLUDE_FROM_ALL
)

FetchContent_GetProperties(cpp_httplib)
if(NOT cpp_httplib_POPULATED)
FetchContent_Populate(cpp_httplib)
add_subdirectory(${cpp_httplib_SOURCE_DIR} ${cpp_httplib_BINARY_DIR} EXCLUDE_FROM_ALL)
endif()
FetchContent_MakeAvailable(cpp_httplib)
7 changes: 2 additions & 5 deletions cmake/logger/coretraceLog.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ include(FetchContent)
FetchContent_Declare(coretrace-logger
GIT_REPOSITORY https://github.com/CoreTrace/coretrace-log.git
GIT_TAG main
EXCLUDE_FROM_ALL
)
FetchContent_GetProperties(coretrace-logger)
if(NOT coretrace-logger_POPULATED)
FetchContent_Populate(coretrace-logger)
add_subdirectory(${coretrace-logger_SOURCE_DIR} ${coretrace-logger_BINARY_DIR} EXCLUDE_FROM_ALL)
endif()
FetchContent_MakeAvailable(coretrace-logger)
7 changes: 2 additions & 5 deletions cmake/stackUsageAnalyzer.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,10 @@ FetchContent_Declare(
stack_analyzer
GIT_REPOSITORY https://github.com/CoreTrace/coretrace-stack-analyzer.git
GIT_TAG v0.17.0
EXCLUDE_FROM_ALL
)

FetchContent_GetProperties(stack_analyzer)
if(NOT stack_analyzer_POPULATED)
FetchContent_Populate(stack_analyzer)
add_subdirectory(${stack_analyzer_SOURCE_DIR} ${stack_analyzer_BINARY_DIR} EXCLUDE_FROM_ALL)
endif()
FetchContent_MakeAvailable(stack_analyzer)

# Copy upstream default models into config/models/ so that tool-config.json
# can reference them with paths relative to the config directory, without
Expand Down
Loading