48 chore refactor codebase and add developer documentation - #49
Merged
SizzleUnrlsd merged 19 commits intoFeb 26, 2026
Merged
Conversation
…, and preparation
14 tasks
There was a problem hiding this comment.
coretrace-stack-analyzer found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
SizzleUnrlsd
deleted the
48-chore-refactor-codebase-and-add-developer-documentation
branch
February 26, 2026 06:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR refactors the project architecture to move core logic out of
main, improve maintainability, and add finer-grained module tests while preserving existing CLI behavior.What Changed
AnalyzerAppas an application-layer orchestrator.ArgParser(usable from CLI and library consumers).AnalysisPipelineModulePreparationServiceDiagnosticEmitterLocationResolverReachabilityfor classifying statically unreachable stack-access findings.mainsimplificationmain.cppnow delegates to parser + app service.coretrace::loggerfor consistency.extern-projectto demonstrate argument forwarding in library mode.stack_usage_analyzer_unit_tests) for:LocationResolverReachabilityModulePreparationService-DBUILD_ANALYZER_UNIT_TESTS=ONrun_test.pyimprovementstest/unit/*from integration fixture scans.README(library-mode argument forwarding + architecture reference).extern-project/README.Architectural Rationale
This split enforces clear boundaries between:
The result is lower coupling, better testability, and safer future evolution with reduced regression risk.
Compatibility
-DBUILD_ANALYZER_UNIT_TESTS=ONValidation
extern-projectbuildrun_test.py)Reviewer Notes
analyseis intentionally excluded from this PR.