Update WGNews.astro - #85
Conversation
The links are showing up left-justified whereas the rest of the text in the news component is showing up center justified. Following GitHub Copilot's guidance to add centering classes to the links container. Why don't I see "justify-center" on any of the "headline" or "body" containers? Copilot's answer: because those elements are being centered by text alignment, not by flex alignment. headline (<h3>) and body (<p>) are plain block/text elements. They’re centered via a parent with text-center (or inherited centering), which affects inline text. justify-center only works on flex/grid containers to align child items along the main axis. So for your links: The <ul> is flex, so it needs justify-center. Without it, flex defaults to justify-start, which is why links sit left. In short: Text elements → text-center Flex item rows → justify-center
|
Let's discuss - I'm not crazy about having a cross-group News Update on each WG page. I left it in the WoA page as you had it since it listed WoA news updates. But having a news bulletin above the fold of each of these pages designed to reference specific WG content seemed a bit busy. That's why I left is out of the other WG summary pages. Perhaps have that elsewhere, or even on the Hub home page? |
|
@dbharbin News was requested by WoA SC. Philip's guidance on design for news & placement wrt fold in COR-112 (13th Aug 09:55 PT). Can discuss Thur |
Make some of the changes discussed with Don: * News headline larger (lg -> xl) * have the link open in a new tab * have the link appear underlined so that it's obvious it's a link without having to hover
|
@dbharbin : First set of changes I made address some of your feedback
Could we merge with just these changes? I suggest to make the left justification with tabbing a separate item that we get @pcolmer help on, because that's beyond what I can muddle through. Whether the news should be at top/bottom/elsewhere can also be addressed in a separate PR after discussion with WoA SC |
2 participants
The links are showing up left-justified whereas the rest of the text in the news component is showing up center justified.
Following GitHub Copilot's guidance to add centering classes to the links container.
Why don't I see "justify-center" on any of the "headline" or "body" containers? Copilot's answer: because those elements are being centered by text alignment, not by flex alignment.
headline (<h3>) and body (<p>) are plain block/text elements. They’re centered via a parent with text-center (or inherited centering), which affects inline text. justify-center only works on flex/grid containers to align child items along the main axis. So for your links:
The
is flex, so it needs justify-center.
Without it, flex defaults to justify-start, which is why links sit left. In short:
Text elements → text-center
Flex item rows → justify-center