Fix Gutenberg JSX runtime dependency loading - #32
Open
Jan-CoreBunch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
gutenberg/index.asset.phpand use its dependency list and content-hash version, with a complete fallback if the manifest is unavailable.Why
The Gutenberg bundle is built with the new JSX transform and calls
window.ReactJSXRuntime.jsx. Its generated asset manifest correctly includesreact-jsx-runtime, but the PHP enqueue code ignored that manifest and used an older hard-coded dependency list. When the runtime was unavailable, rendering the Core Framework block wrapper threw a fatal React error and left the editor blank.WordPress introduced the JSX runtime in 6.6, so Core Framework 2.x now declares 6.6 as its minimum instead of claiming compatibility with WordPress 6.0–6.5.
Verification
Automated checks:
Manual test using the latest WordPress with Twenty Twenty-Four:
typeof window.ReactJSXRuntime?.jsxreturns"function".22d01165d701dd03054a.The remaining
global-styles-css-custom-properties-inline-cssiframe warning is an upstream Gutenberg false positive tracked in WordPress/gutenberg#76082.