fix(oxygen): hide disabled shade and tint variables - #31
Open
Jan-CoreBunch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a Figma save, Oxygen Classic's synchronized global colors correctly contain only active colors, but Core Framework's variable autocomplete can still list obsolete shade and tint variables. Presets retain their
shadesandtintsarrays whenisShadesorisTintsis disabled, and the PHP helpers previously enumerated those arrays without checking the flags. The generated CSS already respects the flags, leaving dropdown entries that point to nonexistent custom properties.The Alt-click Core Framework Variable UI had the same visible symptom because it rendered the retained color-system arrays directly.
Solution
isShades === trueand tints onisTints === truein both variable-list helpers.This does not mutate or clean up persisted preset data; it only prevents disabled variants from being exposed as usable variables or classes.
Validation