-
Notifications
You must be signed in to change notification settings - Fork 731
fix: preserve tool toggle state and filter tools in client listings (rebased #723) #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c513072
fix: preserve tool enabled/disabled state across Unity restarts
whatevertogo 09c61e1
fix: avoid duplicate reregistration and harden tool preference tests
whatevertogo 10754e5
feat: implement tool filtering based on Unity session state in on_lis…
whatevertogo fb17aea
chore: delete State.meta file
whatevertogo 3b624c1
fix: update tool filtering logic to handle user-specific tool lookups…
whatevertogo c67e9f2
fix: add user_id param to execute_custom_tool for remote-hosted mode
whatevertogo fc81d9e
fix: preserve tool state and filter tools in client listings (fixes #…
whatevertogo 1a9b083
fix: add unity_target parameter to mcp_for_unity_tool for improved to…
whatevertogo 07fee1b
fix: update tool filtering logic to defer filtering when no tools are…
whatevertogo 6347c97
fix: add missing using UnityEditor.UIElements for IntegerField
dsarno eeaecba
Merge branch 'fix/preserve-tool-toggle-state-restarts' of https://git…
dsarno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Broad exception handling around ctx.get_state may hide programming/configuration issues
This helper currently catches all
Exceptionfromctx.get_state("user_id")and returnsNone, which can mask real context/configuration bugs (e.g., attribute/type errors). Please narrow theexceptto the specific failure modes you expect fromget_state, or at least log the exception (e.g., at debug level), so genuine integration issues remain visible while still tolerating missing state in normal operation.Suggested implementation:
If
ctx.get_statecan raise more specific, known exceptions (e.g. a custom context error), you should replace or augment the genericExceptionhandler with those specific types so that truly unexpected errors can still propagate.