Repository navigation
Send OpenFuse readers to OpenBot from the top of the README - #233
Draft
jerelvelarde wants to merge 1 commit into
Draft
jerelvelarde wants to merge 1 commit into
jerelvelarde wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main)The problem
OpenFuse is the one skin whose README never got its OpenBot pointer. #220 added one on November 4, but it was written under the old name and was closed unmerged after the rename (#224, #225). So on main, OpenBot first appears at line 213, in the architecture diagram, and nothing links to open.bot. The "OpenBot compatibility" paragraph below it also opens by calling OpenFuse "independent of OpenBot". That is true of this repo's client, but it reads as if OpenFuse has nothing to do with OpenBot, when OpenBot ships an OpenFuse skin.
The approach
This redoes #220 under the new name, in the same shape the OpenDots and OpenDuet READMEs now have:
ref=openfuse_heroare unchanged, so the CTA keeps its attribution.Links meant to send a reader to try or learn about OpenBot go to open.bot. The quick-start row goes to OpenBot on GitHub.
The capture is #220's image, renamed to
assets/openbot-openfuse-skin.png. It was taken on OpenBot's main branch on November 4 and shows no project name, so it is still accurate after the rename.What is not covered
docs/OPENBOT-INTEGRATION.mdand the disabled adapter are untouched.Verification
pnpm test:browser, before this branch. This PR changes only README.md and adds one PNG.mainat 67580f1, after is this branch.app/src/skins/openfuseships in OpenBot v1.1.1, and the skin is picked under Settings → Skin.Merge notes
#223, the duplicate rename PR, still rewrites README.md and now conflicts with main as well as with this branch. Main already has the rename, so #223 should close rather than merge.