Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions apps/server/src/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -296,15 +296,19 @@ export async function createApp(
return c.json({ ok: true });
});
app.post("/api/browsers", async (c) => {
const body = z.object({ url: z.url().max(4096) }).parse(await c.req.json());
const body = z
.object({ url: z.url({ protocol: /^https?$/ }).max(4096) })
.parse(await c.req.json());
return c.json(await browser.create(c.get("owner"), body.url), 201);
});
app.get("/api/browsers/:id", async (c) => {
const owner = c.get("owner");
return c.json(browser.decorate(owner, await browser.get(owner, c.req.param("id"))));
});
app.post("/api/browsers/:id/navigate", async (c) => {
const body = z.object({ url: z.url().max(4096) }).parse(await c.req.json());
const body = z
.object({ url: z.url({ protocol: /^https?$/ }).max(4096) })
.parse(await c.req.json());
return c.json(await browser.navigate(c.get("owner"), c.req.param("id"), body.url));
});
app.post("/api/browsers/:id/close", async (c) =>
Expand All @@ -315,7 +319,14 @@ export async function createApp(
);
app.post("/api/browsers/:id/reopen", async (c) => {
const raw = await c.req.text();
const body = z.object({ url: z.url().max(4096).optional() }).parse(raw ? JSON.parse(raw) : {});
const body = z
.object({
url: z
.url({ protocol: /^https?$/ })
.max(4096)
.optional(),
})
.parse(raw ? JSON.parse(raw) : {});
return c.json(await browser.reopen(c.get("owner"), c.req.param("id"), body.url));
});
app.post("/api/browsers/:id/import-downloads", async (c) =>
Expand Down
54 changes: 54 additions & 0 deletions tests/browser-url-validation.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
import assert from "node:assert/strict";
import test from "node:test";
import { createApp } from "../apps/server/src/app.ts";
import { browserFixture } from "./helpers/browser.ts";

const sessionId = "00000000-0000-4000-8000-000000000002";

test("browser API rejects non-HTTP(S) URLs with 422 without persisting sessions", async (t) => {
const calls: string[] = [];
const { db, config } = await browserFixture(t, (path) => {
calls.push(path);
return { data: {} };
});
const { app, auth, agent } = await createApp(db, config);
t.after(() => agent.stop());
const { token } = await auth.session();
const headers = { Authorization: `Bearer ${token}`, "Content-Type": "application/json" };

await db.put("local-user", "browsers", {
id: sessionId,
title: "Saved",
url: "https://example.com/",
status: "active",
updatedAt: "2026-09-15T00:00:00.000Z",
});

for (const badUrl of ["javascript:alert(1)", "file:///etc/passwd", "data:text/html,hi"]) {
const created = await app.request("/api/browsers", {
method: "POST",
headers,
body: JSON.stringify({ url: badUrl }),
});
assert.equal(created.status, 422);

const navigated = await app.request(`/api/browsers/${sessionId}/navigate`, {
method: "POST",
headers,
body: JSON.stringify({ url: badUrl }),
});
assert.equal(navigated.status, 422);

const reopened = await app.request(`/api/browsers/${sessionId}/reopen`, {
method: "POST",
headers,
body: JSON.stringify({ url: badUrl }),
});
assert.equal(reopened.status, 422);
}

assert.equal(calls.length, 0);
const stored = await db.list("local-user", "browsers");
assert.equal(stored.length, 1);
assert.equal(stored[0].url, "https://example.com/");
});