Require a maintainer's approval to merge - #3
Merged
Merged
Conversation
The repository inherits a collaborator list from the organisation, so about a dozen people can push and, with no review required, merge their own work. That is the wrong default for a public repository. Name the owners explicitly so the protection rule on main has somebody to demand an approval from.
davidmckayv
force-pushed
the
add-codeowners
branch
from
August 17, 2026 02:46
01744c8 to
0ff4401
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.github/CODEOWNERSso the protection rule onmainhas owners to require an approval from.The repository inherits ~30 collaborators from the organisation, around a dozen with write or admin. With
maincurrently requiring 0 approving reviews, any of them could merge their own change with no internal review. That is fine for a private repository two people are building in a weekend, and wrong for a public one.Merging this first, then raising the branch rule to require one code-owner approval, avoids locking the change out of its own gate.