Run the container-boot check only when a PR is a merge candidate - #117
Merged
Conversation
The image job builds the image and boots it, about fourteen minutes. It ran on every pull request and every push to one, while the four checks beside it finish in seconds. That is the bill: the slow job fired on work that was nowhere near merge. It now runs on a pull request only when an admin adds the `full-ci` label, which is the point at which the PR is actually a candidate to merge. On main and through the release workflow_call it still always runs, so nothing reaches a release without having booted. verify already treats a skipped job as a pass, so an unlabelled PR goes green on the cheap checks and the slow one waits until someone means it.
davidmckayv
requested review from
MikeRyanDev,
guidovizoso and
tylerslaton
as code owners
August 21, 2026 22:35
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
imagejob (build the container, boot it, ~14 min) ran on every pull request and every push. The other four checks are seconds. So the slow, expensive one fired on work nowhere near merge — wasted minutes on every push.Now on a pull request
imageruns only when an admin adds thefull-cilabel — the moment the PR is actually a merge candidate. Onmainand through the releaseworkflow_callit always runs, so nothing reaches a release without having booted.verifyalready counts a skipped job as a pass, so an unlabelled PR is green on the cheap checks alone.No behaviour change to what the checks test; only when the slow one fires.