Repository navigation
fix(ci): skip the CLA comment when nothing is missing - #174
Merged
Merged
Conversation
A pull request whose contributors have all signed got the full bot comment, signing statement and all, which read as a request to sign. A passing run now posts nothing; the green CLA status says enough. A comment left by an earlier failing run is still updated to a short passed note, so it stops asking for signatures that have since landed.
Contributor License AgreementAll identified human contributors have signed the current CLA. Current CLA: https://github.com/ConvoyPanel/panel/blob/47c3288b4e4bf24666b78e76986970baa7b398db/CONTRIBUTOR_LICENSE_AGREEMENT To sign, comment exactly: This signature is only for individual contributors who are at least 18 years old. If your contribution is owned by a company, employer, client, school, or other legal entity, don't sign here. It needs separate written permission or a separate contributor agreement instead. Missing signatures:
Commits without a linked GitHub author, requiring maintainer review:
If you already signed, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR whose contributors have all signed still got the full CLA comment, signing statement included, so it read as a request to sign (e.g. #171).
CLAstatus is the signal.Checked by extracting the script and running
node --check. Not exercised live:pull_request_targetruns frommain, so it takes effect on the first PR after merge.