Repository navigation
feat(registry): warn anyone choosing an end-of-life template - #38
Merged
Merged
Conversation
Debian 11 is past LTS and security.debian.org no longer serves its binaries, yet the registry listed it as plain "Debian 11 (Bullseye)". Nothing told a Convoy user, a coport user, or someone logging in to a clone that the guest will never receive another security update. A recipe can now carry `# notice:`, published as the template's `description`. Publish takes `display` and the notice from the recipe rather than the sidecar, so relabelling reaches the registry on the next publish instead of waiting for a rebuild of an image that may never be rebuilt. coport warns with the notice as soon as a template is chosen, before VMIDs are confirmed, in the picker and under --all, --select and --upgrade alike. debian-11 is marked EOL in its display name, the one field every consumer shows, carries a notice, and appends a warning to /etc/motd at build time.
# Conflicts: # recipes/debian-11.pkr.hcl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Debian 11 is past LTS and security.debian.org no longer serves its binaries, but the registry lists it as plain "Debian 11 (Bullseye)". Nothing tells a Convoy user, a coport user, or someone logging in to a clone that the guest will never get another security update.
Change
# notice:header, published as the template's registrydescription.displayand the notice from the recipe, not the sidecar, so relabelling reaches the registry on the next publish without rebuilding the image. A sidecar with no matching recipe is left as built.--all,--selectand--upgrade./etc/motdat build time.Output (coport dry run on a PVE node)
Testing
withRecipeMetadataand# noticeparsing tests pass;bun run typecheckand coport'stscare clean.--selectdry run on a PVE 9.1 node.