Skip to content

Fix update and update-in for higher arities#534

Open
jeroenvandijk wants to merge 1 commit into
Convex-Dev:developfrom
jeroenvandijk:fix/553-update-does-not-apply-all-arguments
Open

Fix update and update-in for higher arities#534
jeroenvandijk wants to merge 1 commit into
Convex-Dev:developfrom
jeroenvandijk:fix/553-update-does-not-apply-all-arguments

Conversation

@jeroenvandijk

@jeroenvandijk jeroenvandijk commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Fixes #533

Added unit tests and fixed the implementation.

The GenesisTest is now failing. I guess this is expected when changing core resources?

[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.045 s <<< FAILURE! -- in convex.core.init.GenesisTest
[ERROR] convex.core.init.GenesisTest.testGenesis -- Time elapsed: 0.044 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <15dce0fe6903633b4ed01aa4452d7250901d5a29cbf7f2c5916c97535ee948da> but was: <6ada1415899d7135697d4823a876a4a5659c97a1d877a4d9affcd44bb5afb17c>

@jeroenvandijk jeroenvandijk changed the title Fix #553 update and update-in for higher arities Fix update and update-in for higher arities Dec 1, 2025
@mikera

mikera commented Mar 2, 2026

Copy link
Copy Markdown
Member

Just to be clear, this fix still very much on cards but need to be vary careful about convex.core changes on Protonet :-)

@mikera

mikera commented May 6, 2026

Copy link
Copy Markdown
Member

(Claude Comment) Thanks @jeroenvandijk — the fix looks good and addresses #533 cleanly. However, update / update-in are core CVM functions, so a behavioural change here has network state implications and needs to land alongside a coordinated network upgrade rather than in a routine point release. Holding this for now; we'll fold it into a release that already carries CVM-semantics changes. Appreciate the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

convex lisp: update doesn't apply all arguments

2 participants