Fix bare exceptions and replace print with logging #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkconcore.py: - Replace 13 bare except: with except (FileNotFoundError, IOError) as e: - Adds actual error message to logs for better debugging concore.py: - Add import logging with basic configuration - Replace 25+ print() statements with appropriate logging levels - logging.info() for status messages - logging.warning() for retries and non-critical issues - logging.error() for errors and failures This improves debugging experience and follows Python best practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix bare exception handling in mkconcore.py and replace print statements with proper logging in concore.py.
Changes
mkconcore.py
except:withexcept (FileNotFoundError, IOError) as e:concore.py
import loggingwith basic configurationprint()statements with appropriate logging levels:logging.info()for status messageslogging.warning()for retries and non-critical issueslogging.error()for errors and failuresWhy This Matters
except:catches ALL exceptions including KeyboardInterrupt and SystemExitprint()statements can't be controlled or redirectedTesting
All tests pass locally:
