feat(inference): suggest implicit foreign-key relationships#463
Open
seonghobae wants to merge 1 commit into
Open
feat(inference): suggest implicit foreign-key relationships#463seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Standalone against main (self-contained: reads snapshot JSON, no foundation deps). GET /api/snapshots/{uuid}/inferred-relationships proposes undeclared FKs for reverse-engineering DBs that never declared them: <X>_id -> same-schema table X/Xs with a PK, excluding declared FKs + own-PK self-loop; confidence high/medium by type match. IDOR-safe, +6 tests.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AxU2xaupAjp912oDNFuWyd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independent PR against
main(replaces #444, which was needlessly stacked onadhesive-piper).GET /api/snapshots/{uuid}/inferred-relationshipsproposes implicit foreign keys a DB never declared — the core value for reverse-engineering legacy/analytics schemas. Heuristic:<X>_idcolumn → a same-schema tableX/Xswith a PK; excludes already-declared FKs and a table's own PK.confidence: highwhen the column type matches the referenced key, elsemedium, each with areason.Self-contained (
app/spec/relationship_inference.py, no foundation deps), IDOR-safe endpoint. backendpytest+6 (incl. a TDD-caught self-PK false positive); mypy clean.🤖 Generated with Claude Code