feat(inference): suggest implicit foreign-key relationships#444
Open
seonghobae wants to merge 2 commits into
Open
feat(inference): suggest implicit foreign-key relationships#444seonghobae wants to merge 2 commits into
seonghobae wants to merge 2 commits into
Conversation
infer_relationships(snapshot) proposes undeclared FKs for reverse-engineering DBs that never declared them: a '<X>_id' column -> a same-schema table X/Xs with a PK, excluding already-declared FKs and a table's own PK (no self-loop). Confidence high when column type matches the referenced key, else medium. Endpoint GET /api/snapshots/{uuid}/inferred-relationships (IDOR-safe). Pure/dialect-agnostic; +6 tests (TDD caught a self-PK false positive). Backend suite 264.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AxU2xaupAjp912oDNFuWyd
Same one-line union-attr fix as on adhesive-piper; makes backend CI (mypy) green on this stacked branch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AxU2xaupAjp912oDNFuWyd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
adhesive-piper(PR #440). Implements P1 "relationship inference" fromdocs/valuation-gap-analysis.md.Reverse-engineering undeclared relationships
GET /api/snapshots/{uuid}/inferred-relationshipsproposes implicit foreign keys that a database never declared — the core reason to use a schema-intelligence tool on legacy/analytics schemas over a generic ERD drawer.Heuristic (high-precision, few false positives): a
<X>_idcolumn → a same-schema tableX/Xsthat has a PK; excludes already-declared FKs and a table's own PK (no self-loop).confidence: highwhen the column type matches the referenced key, elsemedium, each with areason.Pure/dialect-agnostic (
app/spec/relationship_inference.py), IDOR-safe endpoint.Verification
backend
pytest264 passed (+6). TDD caught a real self-PK false positive before merge.Next (stacked): frontend surfacing — suggested relationships as dashed edges with one-click "add to diagram".
🤖 Generated with Claude Code