Skip to content

fix(dom): preserve model-declared blank pages - #958

Draft
seonghobae wants to merge 1 commit into
sentinel/fix-dos-risk-in-form-fields-10499323731269682757from
fix/dom-empty-page-preservation-20260928
Draft

seonghobae wants to merge 1 commit into
sentinel/fix-dos-risk-in-form-fields-10499323731269682757from
fix/dom-empty-page-preservation-20260928

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Summary

Preserve model-declared blank pages when other pages contain indexed content. The shared DOM builder previously iterated only content indices, so a three-page document with a blank middle page returned pages 1 and 3.

This PR is stacked on #822 at 927ff2dec160a00ed11ec045727a422ff7ba4cbd to preserve the existing security owner changes. Its unique delta is two production lines and one synthetic regression test. Merge after #822 and retarget to develop; do not bypass its review/security gates.

Verification

  • Regression failed before the fix: expected [1, 2, 3], received [1, 3].
  • Full suite: 487 passed in 12.04s, warnings as errors; production statement and branch coverage 100%.
  • Ruff and git diff --check passed.
  • Tests ran from this worktree with PYTHONPATH=src using the existing Python 3.13.15 supplier virtual environment. No dependency installation or lock changes.

The test preserves blank-page dimensions and surrounding content. Actual GPU OCR, MinerU 4 migration, model quality, and deployment remain unverified; this repairs the existing shared DOM contract independently.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: ContextualWisdomLab/newsdom-api/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 14fc2776-c734-4d0c-bfa8-be7b1e5e790f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

Exact-head admission correction — 65696f393224a1e08ab42fff5151cbf3639a8a4e

Ready is review admission only. Fresh audit against base 927ff2dec160a00ed11ec045727a422ff7ba4cbd found:

  • mergeability=false on current base

This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed.

@seonghobae
seonghobae marked this pull request as draft September 30, 2026 05:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant